Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in the Neighbours widget #6942

Open
janezd opened this issue Nov 29, 2024 · 0 comments
Open

Change in the Neighbours widget #6942

janezd opened this issue Nov 29, 2024 · 0 comments

Comments

@janezd
Copy link
Contributor

janezd commented Nov 29, 2024

@BlazZupan started a discussion about the Neighbours widgets. He basically, wanted an output Data with distances to all data instance, and overlooked that he can achieve the same effect by unchecking the checkbox that limits the number of neighbours.

Here are some notes:

Neighbours:

  • Add missing distances (normalized Euclidean and Manhatta). (Note to self: an input with distances is not a solution because it would incur quadratic time complexity).
  • Add an output Data with all instance and their distances to the reference, and make it lazy. The output is superfluous, but somehow consistent with other widgets that output subsets, and it's harmless if lazy.
  • Perhaps: remove the checkbox, keep line edit. This is still a matter of discussion; removing the checkbox requires some code for backward compatibilitty.

We also discussed how to provide distances to multiple references. One option was an additional input to Distances of type Data Table that would represent reference examples), and an output with distances to all those instance. The problems with this solution are

  • potentially many meta columns with distances
  • Distances can currently be connected only to a few widgets, which is nice. With the additional output, it can be connected to almost everything, so the pop-up is populated with lots and lots of widgets.
  • We want additional options, like a column that contains an id of the closest reference, or some kind of aggregation (min, max, avg) of distances to refrences.

We haven't decided anything, but it seems this calls for a new widget.

@markotoplak markotoplak transferred this issue from biolab/orange-canvas-core Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant