Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate single environment test into its own workflow #7

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

markotoplak
Copy link
Member

This is a refactor which should not break anything.

If single environment tests are separated, add-ons call test specific additional environments. For example:

jobs:
  normal:
    name: Usual
    uses: biolab/orange-ci-cd/.github/workflows/test-addons.yml@master
  dask:
    name: Dask
    uses: biolab/orange-ci-cd/.github/workflows/test-single-env.yml@master
    with:
      os: ubuntu-latest
      python-version: '3.10'
      tox_env: dask
      pyqt: '5.15.*'

The above worklow runs the standard add-on tests plus an additional test with a specific tox environment (dask). See Quasars/orange-spectroscopy#702 for that PR.

@JakaKokosar
Copy link
Member

I would rename 'test single environment' to something simpler like 'test job'. I was just confused because I didn't understand what single env referred to. It all made sense later.

I think we can merge, looks nice, thanks!

@markotoplak
Copy link
Member Author

Thanks for the better name. I'll wait to see if my PR tests run and then merge.

@markotoplak markotoplak merged commit e02ac10 into master Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants