Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

If version requested for npm package is 'latest', we don't need to verify if version is valid as it is always valid. #26

Open
Nikhil-Vats opened this issue Jul 1, 2019 · 2 comments

Comments

@Nikhil-Vats
Copy link
Member

Description

When we import build file from npm, we ask the user for package name and version. In most cases, the version requested will be latest and if it is latest we don't need to verify it exists because it always does.

Steps to Reproduce

Use the generator and when generator asks for version just press enter (as latest is default) or enter latest, it will take time to show you the next prompt because it will verify the version.

Expected Behaviour

The generator should not check for the version if it is latest.

Actual Behaviour

The generator unnecessarily checks whether version is valid or not and this takes time.

@sarthak-sehgal
Copy link
Contributor

@Nikhil-Vats can this issue be closed?

@Nikhil-Vats
Copy link
Member Author

No. It's an easy fix. I will mostly fix this in this week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants