OS X build + integration tests #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Now using bit-sized pixels; * Redimensioning the image to a fixed width; * Outputting split images
* Added number_of_rows_per_batch parameter; * Removed tiff compression methods by default - png is good enough; * Now extracting COBS header and writing it in a separate, uncompressed binary file;
…index ... and a self check mechanism when compressing the index
Support all fasta file extensions listed in Wikipedia
|
@iqbal-lab is there anyone I should add as a reviewer, or am I free to merge whenever I want? |
|
Pinging you again @iqbal-lab , as I have to merge this very soon |
|
go ahead! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes COBS build for OS X and adds 6 integration tests to ensure it is working on Mac for the MOF paper. However, the AIO feature is removed for the OS X build (still works on linux). Closes bingmann#11