Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Click Interaction] Improve poor click interactions for bottom navigation items whose content height is not enough to reach the offset. #1

Closed
binchoo opened this issue May 17, 2021 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@binchoo
Copy link
Owner

binchoo commented May 17, 2021

[Test case]
https://jsfiddle.net/1dwxk7nh/4/

[Precondition]

  • The height of contents near bottom of the screen is not tall enough to reach the offset of Gumshoe.
  • Smooth scrolling disabled.

[Step]

  1. Click the nav item: 'Miney'.

[As-Is]

  • When 'Miney' is clicked, the screen scrolls to the bottom of document and 'Mo' gets activated.
  • In consequence, nav item: 'Miney' never get activated.

[To-Be]

  • If a navigation item is clickable and activatable, its click interaction and activation should have consistency.

GIF 2021-05-17 오후 11-42-32

@binchoo binchoo added bug Something isn't working enhancement New feature or request labels May 17, 2021
@binchoo binchoo self-assigned this May 17, 2021
@binchoo
Copy link
Owner Author

binchoo commented May 17, 2021

Issues on cferdinandi/gumshoe: cferdinandi#127

@binchoo
Copy link
Owner Author

binchoo commented May 17, 2021

Test URL:
https://binchoo.tistory.com/41

Fixed:
36f258d

As-Is:

var spy = new Gumshoe('#my-awesome-nav a', { click: true });

GIF 2021-05-18 오전 12-03-37

Next: Make it handle smooth scrolling of html/body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant