Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An in-range update of events is breaking the build 🚨 #83

Open
greenkeeper bot opened this issue Jan 8, 2020 · 0 comments
Open

An in-range update of events is breaking the build 🚨 #83

greenkeeper bot opened this issue Jan 8, 2020 · 0 comments

Comments

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Jan 8, 2020

The dependency events was updated from 3.0.0 to 3.1.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

events is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Release Notes for v3.1.0

events now matches the Node.js 11.12.0 API.

  • pass through return value in wrapped emitter.once() listeners

    Now, this works:

    emitter.once('myevent', function () { return 1; });
    var listener = emitter.rawListeners('myevent')[0]
    assert(listener() === 1);

    Previously, listener() would return undefined regardless of the implementation.

    Ported from nodejs/node@acc506c

  • Reduce code duplication in listener type check (#67 by @friederbluemle).

  • Improve emitter.once() performance in some engines

Commits

The new version differs by 15 commits.

  • 4f03fbf 3.1.0
  • 0754cd5 improve emitter.once() performance
  • 7ad7ba6 pass through return value in onceWrapper()-ed functions
  • ade7481 remove dollar symbol for private function
  • 3b825ea Consolidate listener checks (#67)
  • 0a84716 Consolidate listener checks
  • 7b91104 Add FUNDING.yml.
  • 203bd09 Add security.md
  • 21a6ea5 Disable package-lock.json.
  • a7eb04c Merge pull request #59 from Gozala/airtap-1
  • 9b3853b Update airtap to v1.0.0.
  • bda6f8a Merge pull request #57 from Gozala/airtap-0.0.9
  • d598613 Update airtap to 0.0.9.
  • f6f6a37 Merge pull request #55 from Gozala/fix/iphone
  • cd39248 Update airtap and add iPhone back to test matrix

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants