fix: (Re)move sidecars with no data files #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not really: several examples have started to diverge from their "source" data and AFAICR we always said this was fine, though as mentioned here it would be nice if the target data was on openneuro and "we" (bids maintainers and dataset curators) were given access to it. |
effigies
added a commit
to effigies/legacy-bids-validator
that referenced
this pull request
Aug 6, 2024
effigies
added a commit
to effigies/legacy-bids-validator
that referenced
this pull request
Aug 7, 2024
|
Going to go ahead and merge, as these are invalid files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detected by https://github.com/bids-standard/bids-validator/pull/2057.
@Remi-Gau I think you're clearer on the processes here. Is there a process for fixing upstream?