Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration guide: Missing Plane3d -> InfinitePlane3d #1536

Closed
jf908 opened this issue Jul 5, 2024 · 1 comment · Fixed by #1565
Closed

Migration guide: Missing Plane3d -> InfinitePlane3d #1536

jf908 opened this issue Jul 5, 2024 · 1 comment · Fixed by #1565
Labels
A-Migration Guides C-Correction A typo, problem or factual issue in what we've written
Milestone
Release v0.14

Comments

@jf908
Copy link
Contributor

jf908 commented Jul 5, 2024

In this PR bevyengine/bevy#12426, the Plane3d type was renamed to InfinitePlane3d and Plane3d became a type for finite planes so it now has an extra constructor parameter for size.

I think this counts as a breaking change and should be included in the 0.13->0.14 migration notes?
@alice-i-cecile alice-i-cecile added this to the Release v0.14 milestone Jul 5, 2024
@alice-i-cecile alice-i-cecile added A-Migration Guides C-Correction A typo, problem or factual issue in what we've written labels Jul 5, 2024
@andristarr
Copy link

I guess this will need to be done by the maintainers? As the automation to pick up migration guide notes from a PR is ran when the PR is being merged

@rparrett rparrett mentioned this issue Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Migration Guides C-Correction A typo, problem or factual issue in what we've written
Projects
None yet
Milestone
Release v0.14
Development

Successfully merging a pull request may close this issue.

0.14 migration: Add section for Plane3d changes rparrett/bevy-website
3 participants
@jf908 @alice-i-cecile @andristarr