Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog and contributors tools can fail to find PRs #1518

Open
alice-i-cecile opened this issue Jul 4, 2024 · 1 comment
Open

Changelog and contributors tools can fail to find PRs #1518

alice-i-cecile opened this issue Jul 4, 2024 · 1 comment
Labels
C-Automation Tools to make repetitive tasks easier C-Bug A problem with the code that runs the site S-Ready-For-Implementation The core questions are answered: just add code

Comments

@alice-i-cecile
Copy link
Member

IMO: all of the missed PRs look like they got excluded because they were originally opened before the "from" date for the release

Discovered in #1516 / #1517.
@alice-i-cecile alice-i-cecile added C-Bug A problem with the code that runs the site S-Ready-For-Implementation The core questions are answered: just add code C-Automation Tools to make repetitive tasks easier labels Jul 4, 2024
@ChristopherBiscardi
Copy link
Contributor

get_issues_and_prs gets all PRs since the origin date, which is going to be roughly 0.<last_major>.1's date. That set of PRs is what is is checked so any PR opened before that will not be included because the issues endpoint can not be sorted by "closed date". I believe the default sorting for the issues endpoint is "id, descending".

The older PRs may have to be fetched by id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Automation Tools to make repetitive tasks easier C-Bug A problem with the code that runs the site S-Ready-For-Implementation The core questions are answered: just add code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChristopherBiscardi @alice-i-cecile