Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate-release must be run from the generate-release folder #1465

Closed
BD103 opened this issue Jun 27, 2024 · 1 comment · Fixed by #1579
Closed

generate-release must be run from the generate-release folder #1465

BD103 opened this issue Jun 27, 2024 · 1 comment · Fixed by #1579
Assignees
Labels
A-Build-System C-Bug A problem with the code that runs the site D-Straightforward

Comments

@BD103
Copy link
Member

BD103 commented Jun 27, 2024

generate-release assumes that it is run from the generate-release folder, so it always writes to ../release-content. This is an issue when it is called from the root directory using cargo run -p generate-release, and tripped me up when I first started using the tool.

I propose that generate-release always switch into the correct directory, so it can keep these assumptions. If this were a shell script I'd do something like the following, but it may be more involved for Rust:

# Switch to script's directory, letting it be called from any folder.
cd $(dirname $0)

@BD103 BD103 added C-Bug A problem with the code that runs the site A-Build-System D-Straightforward labels Jun 27, 2024
@alice-i-cecile
Copy link
Member

This tripped me up too; we should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System C-Bug A problem with the code that runs the site D-Straightforward
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants