Add metered connection and usability check #4168
Conversation
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
haslinghuis
force-pushed
the
metered-connection
branch
4 times, most recently
from
539650e
to
0aebfdd
Compare
|
essentially this PR checks for "slow" connection and switches to a "disconnected-mode", correct? edit: "disconnected-mode" here seemingly only build-options -- looks good. maybe can be expanded in future, unsure what other needs exist. |
|
Correct. build-options come from flight controller directly. Also
|
haslinghuis
force-pushed
the
metered-connection
branch
from
381fd2c
to
e3cb5b3
Compare
|
nice: |
|
🤔 About measurement: https://accreditly.io/articles/detecting-a-slow-internet-connection-in-javascript Also (seemingly available) official documentation still points to
The part of PWA where much API's are still in development or experimental is a gray zone. Okay let's use inverted logic here instead of measuring connection. |
haslinghuis
force-pushed
the
metered-connection
branch
from
ad65bc2
to
3375646
Compare
haslinghuis
changed the title
|
@nerdCopter had tried to make it more intelligent, but will add too much code and state tracking. So instead of using inaccurate measurements just let the user decide to disable in app internet communication |
|
on the taskbar, where you had |
|
@nerdCopter Moved connection info to setup tab
Would like to reserve the taskbar for something else. |
|
hmmm, okay, but but maybe user should know status when not connected 🤷 |
|
@nerdCopter Would really like a icon as indicator, but struggling finding svg in correct size and putting it in place. Was playing with Screencast.from.19-09-24.18.30.00.webm |
|
i suspect already using some fancy font pack no? |
|
Yes tried fontawesome snippets already - not showing up 😕
|
|
We already have an indicator 😂 |
|
translations for RU & UA: |
|
there is a SonarCloud however. |
|
@nerdCopter remaining issues are html and css related and just extends existing code which needs overhaul anyway. |
haslinghuis
force-pushed
the
metered-connection
branch
from
2497ff2
to
675410a
Compare
haslinghuis
force-pushed
the
metered-connection
branch
from
675410a
to
2045b46
Compare
|
fixes Slow or delayed connection during weak internet connection #4165
reference: https://wicg.github.io/netinfo/
adds option for user to disable connection when on metered or slow connection
indicator on firmware flasher tab
connection info on setup tab
for future improvement we could add an icon for connection status.