-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Driver interface changes #377
Comments
I like the idea of moving stuff the a |
That's the idea. |
I would say go for it! 💪 |
I've done some research (previous assumptions were purely based on the driver interface and it's implementations): looks like it would be quite hard to make peek and count removed from the interface, but at the same time kept as an optional feature. I'm not really happy to say this, but without major refactor on the queue level as well removing those methods is not possible. While I think it would be great if we could remove those things from the interface, I believe this part of the library is mature enough to be ready for a first stable. As @henrikbjorn said: the driver concept is an internal thing, end users (devs) should not meet with the interface at all. I will do some more research, but it looks like it would be easier for us (at least for now) to leave them be. As for the other changes: I still think those should be done, but I wonder if they should block releasing 1.0.0. |
Cleanup
As mentioned in #224 I believe the Driver interface needs a little bit of cleanup.
Currently it's not really an abstraction, and part of the problem is this also reaches the Queue abstraction layer.
Talking about three methods in particular:
These are never used in the consumer-producer context (which I think is the primary goal of Bernard), I believe they are there for the sake of Juno.
Other changes
I also suggest the following changes:
If you are comfortable with these changes I'm more than happy to do the changes and move Bernard towards a stable version.
The text was updated successfully, but these errors were encountered: