DBAL-based queue constantly raises SQL-level errors

[Ocramius]

As per

bernard/src/Driver/DoctrineDriver.php

Lines 40 to 45 in 3b78158

	try {
	$this->connection->insert('bernard_queues', ['name' => $queueName]);
	} catch (\Exception $e) {
	// Because SQL server does not support a portable INSERT ON IGNORE syntax
	// this ignores error based on primary key.
	}

, bernard tries to constantly bash the DB with INSERT statements that will fail.

While this seems to be acceptable at first, some database engines mark transactions with failed SQL statements as "failed transactions", rendering the entire DB connection unusable.

Few things to be done here

• wrap the entire statement in a transaction (safest way)
• use INSERT IGNORE (not always supported, therefore not going there)
• do a SELECT and then an INSERT (relatively low-risk, since queues don't get destroyed/recreated often)

I'll provide a patch for this today, if this seems reasonable.

[henrikbjorn]

Chose the one you think is best. The reasoning seems solid.

[Ocramius]

Provided patch in #252. Patch is against 0.x, since that's what I rely on, but I can also forward-port it to master for you, once it is reviewed/acceptable.

[sagikazarmark]

@acrobat I can see you worked on this. Are you planning to rebase and resubmit it?

[acrobat]

Uhm let me see if I can dig this up again 😄