Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move max-messages and max-runtime into subscribers #149

Open
sagikazarmark opened this issue Jan 5, 2015 · 1 comment
Open

Move max-messages and max-runtime into subscribers #149

sagikazarmark opened this issue Jan 5, 2015 · 1 comment

Comments

@sagikazarmark
Copy link
Contributor

In the consumer the max-messages and max-runtime configuration is quite ugly IMO. I would add a cycle event to the end of the while, so these checks are:

  • optional, only done when a subscriber is added
  • removed from consumer making it much cleaner

What do you think @henrikbjorn?
@sagikazarmark sagikazarmark mentioned this issue Jan 5, 2015
Closed
@henrikbjorn
Copy link
Contributor

I have plans on refactoring the Consumer in a way that would allow using the pthreads extension. Also this makes it impossible to configure this stuff from the cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@henrikbjorn @sagikazarmark