missing display name for trial owners

[saracarl]

A lot of trials (project owner account creation) don't end up with a display name:

This is a problem. Can we require it? Or is it missing for some other reason?

(I feel like there's an open issue on this, but I can't find it.)

[WillNigel23]

Upon further investigation, we found out this happens when a user updates their real name to contain " " rather than just leave it blank (to be nil)

This will then update display_name to be an empty space string ' '

  def update_display_name
    if self.owner
      self.display_name = self.real_name
    else
      self.display_name = login
    end
  end

So that the override will detect that self[:display_name] is NOT nil so it grabs the empty string instead

  def display_name
    if self.guest
      'Guest'
    else
      self[:display_name].presence || self[:login]
    end
  end