Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model should be larger than the entire psf #8

Open
benmontet opened this issue Dec 6, 2017 · 0 comments
Open

model should be larger than the entire psf #8

benmontet opened this issue Dec 6, 2017 · 0 comments

Comments

@benmontet
Copy link
Owner

We were missing the dumb (right) way to calculate the total expected flux from a star in each cadence:

pred_flux = [np.sum(np.exp(model(*results[i], gds))) for i in range(len(tpf)]

Duh. Just calculate the model explicitly and sum over all pixels.

Anyway, when we do this (see the old notebook) we still get too much noise. I think this might be in part because the model region is smaller than the entire PSF and so the movement carries it out of the model region. The residuals look like noise (which is good!) but there is too much of it.

The good news is that we can see the sinusoidal pattern in the data. The residuals aren't quite centered around 0, but I believe this is a background issue and will be fixed when we fix #1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant