Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration is using deprecated DEVICE_CLASS_* constants #36

Open
frenck opened this issue Jan 3, 2023 · 2 comments
Open

Integration is using deprecated DEVICE_CLASS_* constants #36

frenck opened this issue Jan 3, 2023 · 2 comments

Comments

@frenck
Copy link

frenck commented Jan 3, 2023

This custom integration uses deprecated DEVICE_CLASS_* constants in its codebase.

The DEVICE_CLASS_* constants have been deprecated and replaced in Home Assistant Core 2021.12 (over a year ago). I would highly suggest updating/migrating this integration to the new enums.

For example, for the device classes supported by the sensor platform, there is now a SensorDeviceClass enum. So if a sensor previously used the DEVICE_CLASS_ENERGY constant, it should now use SensorDeviceClass.ENERGY. Other platforms (like binary_sensor, and number) provide similar enumerations for their supported device classes.

The migration thus only consists of replacing constants with an enumeration member and is, therefore, very low impact and should be fairly straightforward.

If I can help resolve any questions regarding this change or migration, feel free to ask or respond to this issue. I'm happy to help!

Kindest regards,

../Frenck

@ChristophCaina
Copy link
Contributor

ChristophCaina commented Dec 28, 2023

probably fixed with PR #48 and PR #47
But right now, I am not sure about the 'value' of this integration compared to the core integration...

Comparing the entities of the Core Integration:
grafik
grafik

vs. the custom_component:
grafik
grafik

The custom component is missing the Battery Information (#45)

The Service Calls seem to be the same:
grafik

The only MAJOR difference which I can see, are the attributes for the Binary_sensor of the pet.

Core-Integration:
grafik

Custom-Component:
grafik

@ChristophCaina
Copy link
Contributor

fixed with #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants