Bug in disambiguation in PGN notation

[lucaferranti]

In the attached screenshot, the third move is

3. Ri2

however, this is ambigous as both chariots could reach the i2 point and it needs to disambiguate, i.e. it should be

3. Rii2

(if I'm not mistaken, PGN should disambiguate first by file and then by rank,hence Rii2 instead of R1i2)

[lucaferranti]

for comparison / inspiration: here's my san parser for xiangqi. Cannot take much credit, I adapted the corresponding lichess library to xiangqi, although bugs are most likely my own ^.^

[benckx]

Yes I'm aware of the issue. I made a desambiguation algo to the WXF parser but didn't apply it to other formats. I think I used the same trick as other parsers, i.e. keep all possible interpretations in memory and eliminate the ones that encounter a move that makes no sense or can not be played. With luck at the end there's only 1 valid sequence of moves.

The issue is known but it's possible there was no ticket yet, so I can keep this one.