Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Cannot run a single solver from sklearn #4

Open
ngazagna opened this issue Sep 30, 2020 · 1 comment
Open

[ENH] Cannot run a single solver from sklearn #4

ngazagna opened this issue Sep 30, 2020 · 1 comment

Comments

@ngazagna
Copy link

We cannot run a single solver of sklearn at a time. The following command does not work

benchopt run ./benchmark_logreg_l2 -s sklearn[lbfgs]

and returns

Usage: benchopt run [OPTIONS] BENCHMARK

Error: Invalid value: Patterns ['sklearn[lbfgs]'] did not matched any solver.
Available solvers are:
- Lightning
- sklearn[liblinear]
- sklearn[newton-cg]
- sklearn[lbfgs]

which looks contradictory.

mathurinm pushed a commit to mathurinm/benchmark_logreg_l2 that referenced this issue Nov 24, 2021
@mathurinm
Copy link
Contributor

I can no longer reproduce:

(base) ➜  logreg_l2 git:(main) benchopt run . -s sklearn\[lbfgs\] -d simulated
BenchOpt is running
Simulated[n_samples=200,n_features=500]                                         
|--L2 Logistic Regression[fit_intercept=False,lmbd=1.0]                         
|----sklearn[lbfgs]: done    

I was expecting -s sklearn[lbfgs] to fail because it expected -s sklearn[solver=lbfgs], but it seems that the first syntax works, probably due to:

    parameter_template = "{solver}"

is the sklearn solver. This feature is not documented. Should we keep it @tomMoral ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants