From 7c855054aa8842731dab0c7bf91c04d1a362c9c0 Mon Sep 17 00:00:00 2001 From: Bela Ban Date: Thu, 27 Jun 2024 10:27:23 +0200 Subject: [PATCH] Disallow setting queue in TransferQueueBundler constructor Because it doesn't work as it's overwritten in start --- .../protocols/SimplifiedTransferQueueBundler.java | 5 ----- src/org/jgroups/protocols/TransferQueueBundler.java | 9 --------- 2 files changed, 14 deletions(-) diff --git a/src/org/jgroups/protocols/SimplifiedTransferQueueBundler.java b/src/org/jgroups/protocols/SimplifiedTransferQueueBundler.java index 118d13e152..c5f9b50b4a 100644 --- a/src/org/jgroups/protocols/SimplifiedTransferQueueBundler.java +++ b/src/org/jgroups/protocols/SimplifiedTransferQueueBundler.java @@ -5,7 +5,6 @@ import org.jgroups.util.Util; import java.util.Objects; -import java.util.concurrent.ArrayBlockingQueue; /** * This bundler uses the same logic as {@link TransferQueueBundler} but does not allocate @@ -20,10 +19,6 @@ public class SimplifiedTransferQueueBundler extends TransferQueueBundler { public SimplifiedTransferQueueBundler() { } - public SimplifiedTransferQueueBundler(int capacity) { - super(new ArrayBlockingQueue<>(Util.assertPositive(capacity, "bundler capacity cannot be " + capacity))); - } - public int size() { return curr + removeQueueSize(); } diff --git a/src/org/jgroups/protocols/TransferQueueBundler.java b/src/org/jgroups/protocols/TransferQueueBundler.java index f8b6e17239..0168d12c72 100644 --- a/src/org/jgroups/protocols/TransferQueueBundler.java +++ b/src/org/jgroups/protocols/TransferQueueBundler.java @@ -1,6 +1,5 @@ package org.jgroups.protocols; - import org.jgroups.Message; import org.jgroups.annotations.ManagedAttribute; import org.jgroups.annotations.Property; @@ -44,14 +43,6 @@ public class TransferQueueBundler extends BaseBundler implements Runnable { public TransferQueueBundler() { } - protected TransferQueueBundler(BlockingQueue queue) { - this.queue=queue; - } - - public TransferQueueBundler(int capacity) { - this(new ArrayBlockingQueue<>(Util.assertPositive(capacity, "bundler capacity cannot be " + capacity))); - } - public Thread getThread() {return bundler_thread;} @ManagedAttribute(description="Size of the queue")