Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider popup behavior when data missing #345

Open
GMart opened this issue Nov 7, 2021 · 3 comments
Open

Slider popup behavior when data missing #345

GMart opened this issue Nov 7, 2021 · 3 comments
Labels
General Affects the system in general.

Comments

@GMart
Copy link

GMart commented Nov 7, 2021

Describe the bug
Slider popup does not move correctly when there is a gap in data on graphs

To Reproduce
Have gap in data
Slide mouse cursor back and forth
Popup will not always lag behind the direction the mouse is moving. It sometimes appears to be in the middle of the slider bar. It also glitches around instead of always appearing to the left or right of the line.
It appears on the sensor graph and the thermostat detail graphs.

Screenshot
Screenshot 2021-11-07 Beestat

@GMart
Copy link
Author

GMart commented Nov 7, 2021

I would also like to add a related bug:
On the mobile page, the detail popup stays up when you remove your finger from the graph. I have to tap the graph area, then a blank space so the detail popup will disappear.
Otherwise, this is a great piece of software, thanks for developing it!
-- Fellow Hoosier

@ziebelje ziebelje added the General Affects the system in general. label Dec 15, 2021
@ziebelje
Copy link
Member

I can confirm this bug. The reason for the jitter is because the tooltip is trying to position itself relative to the nearest point, which is to the left or right quite a bit. This starts to happen, but then the tooltip tries to position itself again because there are also hidden points for other purposes.

If I get really bored one day maybe I'll try to fix this one. ;)

As for the mobile tooltip not going away...you're right but I don't think you want it to go away. I tried having it disappear automatically after a few seconds on mobile but then if you're actually looking at the tooltip data it disappears on you. I think the better option is to just show it always on mobile until you click outside the graph. If you have any other ideas let me know.

@GMart
Copy link
Author

GMart commented Dec 29, 2021

Thanks for looking into it!
I think the issue with the mobile tooltip is that is stays even when I start scrolling. Could there be a threshold, so that when you start scrolling at a certain speed or higher, it hides the tooltip? Right now it seems to need two separate taps outside the graph area to hide. (I'm on Android 11, Chrome browser)

Happy Holidays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Affects the system in general.
Projects
None yet
Development

No branches or pull requests

2 participants