From da725c365e3c173537a1a4833e6037bc1024c3ee Mon Sep 17 00:00:00 2001 From: styks1987 Date: Wed, 18 May 2016 16:02:08 -0400 Subject: [PATCH 1/2] remove implementedEvents function This function breaks the whole component. --- src/Controller/Component/ApiPaginationComponent.php | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/Controller/Component/ApiPaginationComponent.php b/src/Controller/Component/ApiPaginationComponent.php index b181d38..136646c 100644 --- a/src/Controller/Component/ApiPaginationComponent.php +++ b/src/Controller/Component/ApiPaginationComponent.php @@ -29,16 +29,6 @@ class ApiPaginationComponent extends Component */ protected $pagingInfo = []; - /** - * {@inheritDoc} - * - * @return array - */ - public function implementedEvents() - { - return []; - } - /** * Injects the pagination info into the response if the current request is a * JSON or XML request with pagination. From 17499cbbbdcf6943983f31ac4574c3084f76c71c Mon Sep 17 00:00:00 2001 From: styks1987 Date: Wed, 18 May 2016 17:10:15 -0400 Subject: [PATCH 2/2] remove test for implemented events --- .../Component/ApiPaginationComponentTest.php | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/tests/TestCase/Controller/Component/ApiPaginationComponentTest.php b/tests/TestCase/Controller/Component/ApiPaginationComponentTest.php index fa0fd34..65c07db 100644 --- a/tests/TestCase/Controller/Component/ApiPaginationComponentTest.php +++ b/tests/TestCase/Controller/Component/ApiPaginationComponentTest.php @@ -40,18 +40,6 @@ public function tearDown() parent::tearDown(); } - /** - * Simple test to check if implementedEvents returns an empty array. - */ - public function testImplementedEvents() - { - $apiPaginationComponent = new ApiPaginationComponent($this->controller->components()); - $result = $apiPaginationComponent->implementedEvents(); - $expected = []; - - $this->assertSame($expected, $result); - } - /** * Test that a non API or paginated request returns null. *