-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lots of audio nodes produced where none need be #6
Comments
I'm pretty sure I've made a big dent in the overall scale of this in bbc/Adhere#84:
There's one further optimisation that we could make, which is, only create a pan node if pan is being modified, and only create a gain node if gain is being modified. Need to make sure we don't make it impossible to implement bbc/Adhere#78 in doing this though. I'm not really sure if it's worthwhile. @robertbryer do you think the issue you originally raised has now been fixed, or are you still seeing significantly too many nodes? |
I think that was the original point I was getting at with issue—it's why the nodes refer to this.input/this.output because the original intention was to allow them to just passthrough as an option (i.e., when you ask for a non-audio-modifying node's output, it could just return its parent's output instead). If you wrapped every |
All audio-participating nodes, that is, all those in the ancestry of leaf nodes, are producing audio nodes for the graph. Nodes in the XML with no audio attributes do no change the audio, but are still producing gain nodes with a gain of 1 and pan nodes with a pan of 0. We should remove these superfluous audio nodes.
The text was updated successfully, but these errors were encountered: