rdkafka-sys has dangling symbolic link with rules rust 0.54.1 and higher #3099
Comments
|
We're experiencing the same issue with |
|
I believe this should be addressed by #3067 That said, I'm kind of surprised this broke, as AFAICT there aren't any relevant changes in that release @UebelAndre It looks like this is a difference caused by flipping A workaround for users is to set |
|
This is caused by the pruning behavior associated with diff --git a/cargo/cargo_build_script_runner/bin.rs b/cargo/cargo_build_script_runner/bin.rs
index 6ae1741e..e94883e7 100644
--- a/cargo/cargo_build_script_runner/bin.rs
+++ b/cargo/cargo_build_script_runner/bin.rs
@@ -530,6 +530,7 @@ impl RunfilesMaker {
})?;
}
}
+ println!("Deleted: {}", abs_dest.display());
continue;
}The intent of this was to try and reduce the amount of inputs being added to downstream Additionally I'm surprised this issue exists at all. I would have expected build-scripts which use cmake to only be installing to |
|
@UebelAndre According to my investigation in #3067 this changes behavior that previously the files which are being installed were not symlinks but an actual copy of those. It seems after switching this flag these files become symlinks. By default cmake preservers the symlinks unless you ask otherwise. |
Maybe we could simply copy all files into the |
|
isn't my proposal acceptable to resolve symlinks in the |
Yeah, I think the proposal sounds fine, I've just yet to look at the PR. For the record though, I did confirm that #3111 (which deletes the symlink behavior) results in successful I can try to find time today to look through your PR 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you try to build rdkafka with rules_rust 0.54.1 you get back this error
For rules_rust 0.53.0 builds successfully.
See https://github.com/spags-lacework/rules_rust_repo/tree/main for a simple repo.
The text was updated successfully, but these errors were encountered: