feat: add Google IAM credentials for Redis password #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonschroeder-sfdc
force-pushed
the
redis-google-iam
branch
from
a14b8a1
to
af2c9cd
Compare
jasonschroeder-sfdc
force-pushed
the
redis-google-iam
branch
from
af2c9cd
to
a2866f7
Compare
jasonschroeder-sfdc
force-pushed
the
redis-google-iam
branch
from
a2866f7
to
b73c91f
Compare
jasonschroeder-sfdc
force-pushed
the
redis-google-iam
branch
from
b73c91f
to
1a4b9c3
Compare
The majority of `GoogleCredentialProvider.java` is inspired by https://cloud.google.com/memorystore/docs/cluster/client-library-connection#jedis Used in accordance to license: > Except as otherwise noted, the content of this page is licensed under the Creative Commons Attribution 4.0 License, and code samples are licensed under the Apache 2.0 License
Use `GoogleCredentialProvider.java` to provide Redis credentials.
jasonschroeder-sfdc
force-pushed
the
redis-google-iam
branch
from
1a4b9c3
to
cd2ecb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support Google Memorystore Redis Cluster to use IAM authentication.
See also: https://cloud.google.com/memorystore/docs/cluster/manage-iam-auth
To provide auth, you can use
GOOGLE_APPLICIATION_CREDENTIALSenv variable to buildfarm containers, or, if you are deployed to Google Cloud, you can use native identity binding.