[refactor] move all the execution wrappers to their own dir #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
luxe
commented
Apr 26, 2023
luxe
commented
- Clean up the main BUILD file
- Clean up miscellaneous files on the root of repo.
werkt
reviewed
Apr 26, 2023
|
|
||
| /** | ||
| * @field asNobody | ||
| * @brief The program to use when running actions as "as-nobody". | ||
| * @details This program is expected to be packaged with the worker image. The linux-sandbox is | ||
| * also capable of doing what this standalone programs does and may be chosen instead. | ||
| */ | ||
| public String asNobody = "/app/build_buildfarm/as-nobody"; | ||
| public String asNobody = "/app/build_buildfarm/src/main/execution_wrappers/as-nobody"; |
There was a problem hiding this comment.
I dislike the idea that we're referencing src/main in runtime applications. Is there a way to relocate this as a part of the deployment?
There was a problem hiding this comment.
Maybe as a class_path resource. I'll try.
|
Conventionally, I think this belongs in /src/execution_wrappers, as it's a non-main component non-language module separation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.