Add Blzmod example to pull.md #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjmaestro
changed the title
|
@thesayyn / @alexeagle this should be a quick review / stamp, it's a simple doc change that I think can be useful for n00bs like me that are new to Bazel and are using Blzmod in a clean repo / greenfield project 😄 Thanks!! |
|
I believe you should update the doc in oci/pull.bzl instead of directly editing the generated file. |
|
@thesayyn eeeh... you are right, of course! dunno how I missed that 😅 I've added the changes to the .bzl file and re-rendered the docs (and rebased the branch). I think it should be ready now 😄 Thanks! |
thesayyn
reviewed
Sep 1, 2024
The documentation only had `WORKSPACE.bazel` examples, so I'm adding one for `MODULE.bazel`. The example I'm using also has a slight "issue" with the architecture variant that (I think) can easily to trip people (like it tripped me).
alexeagle
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation only had
WORKSPACE.bazelexamples, so I'm adding one forMODULE.bazel.The example I'm using also has a slight "issue" with the architecture variant that (I think) can easily to trip people (like it tripped me).