Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Cannot load save from: New Mod" error after changing mod name in config.h #46

Open
Wrymouth opened this issue Mar 22, 2024 · 4 comments

Comments

@Wrymouth
Copy link
Contributor

error message

After changing the name of my dx mod I get this error message on the title screen. The code below gives the impression that this is intended behaviour so that no save data from other mods is accidentally loaded, but it doesn't seem to account for the possibility that a modder might change the mod name themselves.

relevant code

@bates64
Copy link
Owner

bates64 commented Mar 22, 2024

There should be a comment there explaining how to set up save data migrations

@bates64
Copy link
Owner

bates64 commented Mar 22, 2024

You want something like

} else if (strcmp(saveData->modName, "New Mod") != 0) {
    ver_deserialize_idk_your_mod_save(saveData);
} else if ...

@bates64
Copy link
Owner

bates64 commented Mar 22, 2024

Perhaps we can catch "New Mod" and have a specific error message that points to a guide on how to do save data migrations

@bates64
Copy link
Owner

bates64 commented May 25, 2024

Let us know if #66 fixes this / makes it more obvious what to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants