Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Request/Assertions implementation classes final #46

Open
KPull opened this issue Nov 17, 2016 · 1 comment
Open

Make Request/Assertions implementation classes final #46

KPull opened this issue Nov 17, 2016 · 1 comment
Labels
enhancement
Milestone
1.0

Comments

@KPull
Copy link
Member

KPull commented Nov 17, 2016

Our Request and Assertions subclasses are not final in the sense that anyone can subclass them. This is NOT the intended use of these classes and should be marked final. If someone would like to extend their functionality, they should compose the classes rather than subclass them.
@KPull KPull added this to the 0.4-BETA milestone Nov 17, 2016
@KPull
Copy link
Member Author

KPull commented Nov 22, 2016

Should we do this? Alternatively we can indicate the intended use in each class' JavaDocs.

@KPull KPull modified the milestones: 0.4-BETA, 0.5-BETA Dec 8, 2016
@KPull KPull modified the milestones: 0.5-BETA, 0.6-BETA Jan 3, 2017
@KPull KPull modified the milestones: 0.6-BETA, 1.0 Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@KPull