Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicate the Google Books API for testing #26

Open
KPull opened this issue Sep 8, 2016 · 3 comments
Open

Replicate the Google Books API for testing #26

KPull opened this issue Sep 8, 2016 · 3 comments
Labels
Milestone

Comments

@KPull
Copy link
Member

KPull commented Sep 8, 2016

One of our tests, GoogleBooksApiTest, uses the actual Google API endpoint for testing. Unfortunately, this has been found to change. We need to replicate the responses using our own embedded server and point the GoogleBooksApiTest to our embedded test server.

@KPull
Copy link
Member Author

KPull commented Nov 24, 2016

I've marked GoogleBooksApiTest as ignored for the meantime. Remove the @Ignored annotation when this is done.

@FrelliBB
Copy link
Member

FrelliBB commented Dec 5, 2016

Isn't this what the embedded Sushi API is for?

@KPull
Copy link
Member Author

KPull commented Dec 5, 2016

Yes and, in fact, this should go along with the embedded test server. I suggested to replicate the Google Books API, because it returns a massive amount of data compared to the Sushi API. There were problems (related to character encoding, for example) when I called the Google Books API. By copying at least one call to our embedded server, we guarantee that the data won't change across different test runs.

@KPull KPull modified the milestone: 1.0 Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants