Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: query text editor #4

Open
DanielHe4rt opened this issue Aug 22, 2024 · 6 comments
Open

feat: query text editor #4

DanielHe4rt opened this issue Aug 22, 2024 · 6 comments
Assignees
Labels
discussion Something which needs discussion before implementing question Further information is requested

Comments

@DanielHe4rt
Copy link
Contributor

Feature: Query Text Editor

reedline
ratatui-weird-stuff

The primary and only feature of CQLSH is his powerful REPL integration, thinking on that IMHO this will be the hardest feature to be implementing.

Here we have a couple of possibilities:

  • Use one of Ratatui integrated library: ratatui-textarea
  • Use Reedline which has tons of ready to use features: reedline
  • Create something from scratch

Let's use this issue to discuss about this feature for now.

@DanielHe4rt DanielHe4rt added question Further information is requested discussion Something which needs discussion before implementing labels Aug 22, 2024
@Tomcat-42
Copy link

IMHO reedline will be the best option for something like that. If we can achieve at least 10% of the Nushell experience, that would be great.

@Tomcat-42
Copy link

If no one has started working on this, I would like to tackle it.

@Daniel-Boll
Copy link
Collaborator

@Tomcat-42 Could you try to create a POC integrating the reedline terminal in the defined layout?

Also apart from reedline there is also rustyline, but I think reedline is more mature.

Another positive point about reedline is that there is already a repo that implements a REPL on top of it reedline-repl-rs

@DanielHe4rt
Copy link
Contributor Author

@Tomcat-42 let us know if you have any WIP. You can also open a draft in case you make some progress there :p

@Tomcat-42
Copy link

@DanielHe4rt Ok, will do that.

@Daniel-Boll
Copy link
Collaborator

From what I tested it may be difficult, reedline kinda wants to occupy everything, at least with the defaults. We need to find a way to render it only within our constraints, sort of like a iframe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Something which needs discussion before implementing question Further information is requested
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants