Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second exception with Sequelize not caught #10

Open
kennu opened this issue Mar 22, 2013 · 4 comments
Open

Second exception with Sequelize not caught #10

kennu opened this issue Mar 22, 2013 · 4 comments

Comments

@kennu
Copy link

kennu commented Mar 22, 2013

Connect-domain works for me if I simulate async errors with a setTimeout(...) callback. But when I use a Sequelize data model to make an SQL query, and throw an error inside its callback, connect-domain catches the exception only once. Reloading the browser page causes Node.js to crash. Any idea what's going on?

I'm using

expressApp.use connectDomain()
... set up views that use Sequelize ...
expressApp.use express.errorHandler(dumpExceptions:true, showStack:true)
@baryshev
Copy link
Owner

What version of connect-domain and node.js do you use?

@kennu
Copy link
Author

kennu commented Mar 22, 2013

Node.js 0.8.22, connect-domain 0.5.0

@dstibrany
Copy link

I'm having the exact same issue on node 0.8.26 and connect-domain 0.5.0.

I'm going to upgrade to node 0.10 and see if that fixes it.

@dstibrany
Copy link

It does not work in node 0.10.22.

The first exception gets caught by the domain, the second exception crashes the server.

My exception is being thrown in a callback function from a call to postgresql; Like @kennu I also cannot replicate this using setTimeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants