Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract ether to arbiatry erc20 token. #7

Open
barryWhiteHat opened this issue May 2, 2018 · 4 comments
Open

Abstract ether to arbiatry erc20 token. #7

barryWhiteHat opened this issue May 2, 2018 · 4 comments

Comments

@barryWhiteHat
Copy link
Owner

This will allow use with any token. To do this we need to replace

    mapping (bytes32 => bool) roots;
    mapping (bytes32 => bool) nullifiers;

with

    mapping (address => bytes32 => bool) roots;
    mapping (address => bytes32 => bool) nullifiers;

where address is the token address being mixed.

@HarryR
Copy link

HarryR commented Jul 9, 2018

#13 ?

Where the 'zero address' could be Ether.

Alternatively you could split the logic into a common backend contract, which can be reused by multiple frontend contracts supporting different token types (e.g. ERC-721, ERC-20)

@barryWhiteHat
Copy link
Owner Author

@davidp94 can you give an update re #13

Yeah so that is the current plan. But that PR is for the old version based upon javascipt. This PR needs to be updated to work with python and add tests, update the example scripts.

@davidp94
Copy link

davidp94 commented Jul 10, 2018 via email

@barryWhiteHat
Copy link
Owner Author

Ah cool that sounds gr8 :)

@nvonpentz was interested in UI. @nvonpentz are you still interested? We should make an issue for this and do a call on gitter. Once we have tokens and an idea about transaction abstraction we should be ready for a UI. But would also like to get a better idea about #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants