New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk should throw errors instead of strings #4

Open

remorses opened this issue Apr 20, 2023 · 0 comments · May be fixed by #5

remorses commented Apr 20, 2023

it is good practice to throw Error objects instead of strings, this way you can trace where the error comes from

banana-node-sdk/module/genericsUtils.ts

Line 64 in 8ddc58d

throw `server error: status code ${err.response.status}`

This line should be replaced with throw new Error('error message')

The text was updated successfully, but these errors were encountered:

remorses linked a pull request

that will close this issue

Several improvements and fixes #5

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment