-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS Support #106
Comments
How can we help with iOS support? |
Thanks for asking @developerdanx! On iOS, we haven't investigated much a technical solution yet. For the performance measuring part, I think one possibility would be to use If you'd like to try your hand at a POC, I'd be happy to help out! |
Yes this is feasible I think. I'll try something out and share the results 😁 |
Hi ! Quick update, we are also going to try to develop a POC for iOS in the next few days with @Almouro |
We've deployed the (crude) POC here https://github.com/bamlab/flashlight/tree/main/packages/ios-poc We'll work to make it easier to use in the coming weeks with @GuillaumeEgret 🤞 |
Still in progress, but @GuillaumeEgret managed to have a POC of CPU measures per thread when running a Maestro test Here's an example report: https://65031abea84fdb098fb48ce4--flashlight-open-source-reports.netlify.app/report.html Next is:
|
Hey guys! Is this still ongoing? I'd love to test iOS devices as well |
+1 to see if this iOS support is still in development |
hey everyone 👋 cc: @Almouro |
+1 for this too. How can I help contribute to this effort? I'd like to know what are the technical challenges: is it building the perf app in iOS, or is it installing it on a device (idb hurdle), or something else? |
Sorry it took so long for me to answer this, it's a good idea to sum up a bit where we're at at the moment! Sadly, things are not as easy as on Android, where we can just openly read values from system files. There are 3 elements that are part of the Flashlight philosophy for Android which are tricky to get on iOS:
We have a few approaches that we've tried but are not entirely satisfied with, (and it's also a challenge to dedicate resources to this on our side.) 1st approach: Instruments CLI❌ Live measures On iOS,
It's not totally done still, and there's still this PR open to get it merged that we need to get back to. 2nd approach: using
|
Maybe 1️⃣ together with a video recording? |
Previously, I wouldn’t have chosen 1️⃣ as my go-to, as I loved using Flashlight for live measurements. Recently, however, I’ve started using Flashlight to create performance reports, and it’s been working well for me. I’m also leaning towards 1️⃣ now because it provides thread-by-thread and black-box measurements, which offer a more streamlined developer experience when debugging performance issues |
iOS support isn't a priority at the moment, since on average iOS devices performance is much better (and usually that translates to apps having less performance issues).
However it is still something we want to search into and implement at some point, so if you'd like to have iOS support, feel free to show it by adding a 👍 emoji to this issue.
The text was updated successfully, but these errors were encountered: