Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layers/meta-balena-5x-owa: Start CAN on boot #545

Merged
merged 1 commit into from
Oct 30, 2024
Merged

layers/meta-balena-5x-owa: Start CAN on boot #545

merged 1 commit into from
Oct 30, 2024

Conversation

otlaitil
Copy link
Contributor

@otlaitil otlaitil commented Oct 7, 2024

As discussed in #397 starting CAN communication from within balena docker applications is difficult due to needing owasys libraries in the image and needing to mount sockets to the running container.

I suggest we enable CAN communication by default.

@otlaitil otlaitil mentioned this pull request Oct 7, 2024
Open
@floion floion requested a review from owzagj October 10, 2024 10:17
@owzagj
Copy link
Collaborator

owzagj commented Oct 10, 2024

Change tested on a 6.0.30 image

owzagj
owzagj previously approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@owzagj owzagj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change tested on a 6.0.30 image

@otlaitil
Copy link
Contributor Author

Thanks for testing this out and for the approval. 🙌

How can we get this merged in as I am not a verified contributor? Also, could we get this in to the upcoming release that will be made available in Balena Dashboard? @floion @owzagj

@floion floion force-pushed the improvement/start-can-on-boot branch from c48aa75 to e202789 Compare October 11, 2024 08:40
@floion floion enabled auto-merge October 11, 2024 08:40
@floion
Copy link
Collaborator

floion commented Oct 11, 2024

@owzagj I think this is pending your review

@floion floion requested a review from owzagj October 11, 2024 08:41
owzagj
owzagj previously approved these changes Oct 11, 2024
View reviewed changes
@owzagj
Copy link
Collaborator

owzagj commented Oct 11, 2024

I've approved it twice, once yesterday and right now. Do I need to do anything else?

@floion
Copy link
Collaborator

floion commented Oct 11, 2024

I've approved it twice, once yesterday and right now. Do I need to do anything else?

No, it picked it up now. Thanks

@floion
Copy link
Collaborator

floion commented Oct 11, 2024

Hi @otlaitil your PR must have at least 1 commit that adds a Changelog-entry, such as c728d18
See also https://github.com/balena-os/balena-owa5x?tab=readme-ov-file#contributing

auto-merge was automatically disabled October 11, 2024 10:00

Head branch was pushed to by a user without write access

@otlaitil otlaitil force-pushed the improvement/start-can-on-boot branch from e202789 to bb72c20 Compare October 11, 2024 10:00
@otlaitil
Copy link
Contributor Author

Thanks @floion, I edited the commit message as per the instructions.

@floion floion force-pushed the improvement/start-can-on-boot branch from bb72c20 to a7e618d Compare October 11, 2024 12:55
@floion floion enabled auto-merge October 11, 2024 12:55
@floion
Copy link
Collaborator

floion commented Oct 11, 2024

You also need a Signed-off-by @otlaitil

auto-merge was automatically disabled October 12, 2024 09:34

Head branch was pushed to by a user without write access

@otlaitil otlaitil force-pushed the improvement/start-can-on-boot branch from a7e618d to f77ef24 Compare October 12, 2024 09:34
@otlaitil
Copy link
Contributor Author

@floion added Signed-off-by now - sorry about the trouble!

@otlaitil
Copy link
Contributor Author

Could we get this merged in?

@otlaitil
Copy link
Contributor Author

Sorry for the repeated ping, but this issue is preventing us from using Balena official image with Owa5x currently. Could you please consider merging this in @floion and @owzagj ?

@floion floion force-pushed the improvement/start-can-on-boot branch from f77ef24 to 36bb6e5 Compare October 28, 2024 09:20
@github-actions GitHub Actions
Copy link

A repository maintainer needs to approve this workflow run.

https://github.com/balena-os/balena-owa5x/actions/runs/11550915938

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

@floion floion force-pushed the improvement/start-can-on-boot branch from 36bb6e5 to 34f3f33 Compare October 29, 2024 13:35
@github-actions GitHub Actions
Copy link

A repository maintainer needs to approve this workflow run.

https://github.com/balena-os/balena-owa5x/actions/runs/11575016767

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

@floion
Copy link
Collaborator

floion commented Oct 29, 2024

lgtm

klutchell
klutchell previously approved these changes Oct 29, 2024
View reviewed changes
@floion floion force-pushed the improvement/start-can-on-boot branch from 34f3f33 to 41633c6 Compare October 29, 2024 14:02
@github-actions GitHub Actions
Copy link

A repository maintainer needs to approve this workflow run.

https://github.com/balena-os/balena-owa5x/actions/runs/11575499007

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

@floion
Copy link
Collaborator

floion commented Oct 29, 2024

lgtm

acostach
acostach previously approved these changes Oct 29, 2024
View reviewed changes
@otlaitil @floion
layers/meta-balena-5x-owa: Start CAN on boot
89e3a69 
As discussed in balena-os#397 starting CAN communication from within balena docker applications is difficult due to needing owasys libraries in the image and needing to mount sockets to the running container.

This commit enables CAN on boot.

Changelog-entry: Start CAN on boot
Signed-off-by: Otto Laitila <[email protected]>
@floion floion force-pushed the improvement/start-can-on-boot branch from 41633c6 to 89e3a69 Compare October 30, 2024 07:57
@github-actions GitHub Actions
Copy link

A repository maintainer needs to approve this workflow run.

https://github.com/balena-os/balena-owa5x/actions/runs/11589074704

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

@github-actions GitHub Actions
Copy link

A repository maintainer needs to approve this workflow run.

https://github.com/balena-os/balena-owa5x/actions/runs/11589074695

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

@floion
Copy link
Collaborator

floion commented Oct 30, 2024

LGTM

@github-actions GitHub Actions
Copy link

A repository maintainer needs to approve this workflow run.

https://github.com/balena-os/balena-owa5x/actions/runs/11589074704

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

@flowzone-app flowzone-app bot merged commit 3d054e9 into balena-os:master Oct 30, 2024
50 checks passed
@owzagj
Copy link
Collaborator

owzagj commented Oct 30, 2024

Well done!

@otlaitil
Copy link
Contributor Author

otlaitil commented Nov 3, 2024

Great! Any estimate when this will be available in Balena Cloud? I see that there's some problems with the CD pipeline with the release?

@floion
Copy link
Collaborator

floion commented Nov 4, 2024

Hi, version 6.1.0 is now available in production
Sorry again for the delay

@otlaitil
Copy link
Contributor Author

otlaitil commented Nov 5, 2024

Thank you @floion and @owzagj !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acostach acostach acostach approved these changes

@owzagj owzagj owzagj left review comments

@klutchell klutchell klutchell left review comments

@floion floion floion left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@otlaitil @owzagj @floion @klutchell @acostach