Add device update status/last update status event that devices can report #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Page-
force-pushed
the
device-update-status
branch
2 times, most recently
from
a0dff8c
to
878882b
Compare
Page-
changed the title
Page-
force-pushed
the
device-update-status
branch
from
878882b
to
4540d92
Compare
Page-
force-pushed
the
device-update-status
branch
3 times, most recently
from
e5fb3f0
to
edff86a
Compare
Page-
force-pushed
the
device-update-status
branch
3 times, most recently
from
01fbab0
to
399c0be
Compare
joshbwlng
reviewed
Jul 12, 2024
joshbwlng
reviewed
Jul 12, 2024
Page-
force-pushed
the
device-update-status
branch
from
399c0be
to
1628d67
Compare
thgreasi
reviewed
Aug 9, 2024
| @@ -319,6 +330,22 @@ export const statePatchV3: RequestHandler = async (req, res) => { | |||
| deviceBody.is_running__release = release.id; | |||
| } | |||
| } | |||
| const { releases } = apps[userAppUuid]; | |||
There was a problem hiding this comment.
Since userAppUuid = device.belongs_to__application[0].uuid should we first check whether apps[userAppUuid] is actually there before destructuring it?
Suggested change
| const { releases } = apps[userAppUuid]; | |
| const releases = apps[userAppUuid]?.releases; |
There was a problem hiding this comment.
I think this will only happen in the case that userAppUuid is null, which should be impossible, but I'll add the check regardless
There was a problem hiding this comment.
So interestingly this change you proposed triggers an error
src/features/device-state/routes/state-patch-v3.ts:321:11 - error TS7022: 'device' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.
@thgreasi, I'm not sure why though. And as a check
const releases = apps[userAppUuid].releases;
does not have any issues
Page-
force-pushed
the
device-update-status
branch
4 times, most recently
from
7aacd49
to
a2ae396
Compare
…port Change-type: minor
Page-
force-pushed
the
device-update-status
branch
from
a2ae396
to
7002ae0
Compare
thgreasi
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.