Check that deviceId is defined to handle cutovers from older versions #1350
Conversation
dcaputo-harmoni
changed the title
dcaputo-harmoni
changed the title
|
Hi,
|
|
Oh I should have also mentioned that we need the commit message to also include a
|
| throw new Error( | ||
| `An unexpected value was encountered for the target device state: ${nextState}`, | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
It's probably worth it to also raise such cases with something like:
| } | |
| } else { | |
| const msg = `Unable to consume API heartbeat state message without a deviceId: ${message}`; | |
| errors.captureException(new Error(msg), msg); | |
| } |
There was a problem hiding this comment.
Unfortunately I made this PR using the web editor and it's not letting me amend the commit to include the change-type annotation - so if you guys think it's worthwhile to include probably easiest to just recreate. Either way the issue is solved on my end after running with this change, but might be helpful for others in case they run into this issue. One alternative approach would be just running a cleanup on the redis queues on startup, similar to how the database migrations occur.
There was a problem hiding this comment.
Hi @dcaputo-harmoni ,
Let me guide you on how to do this so that you can get the credits from doing this PR.
1a. In case you do not have a local copy of open-balela-api you will first need to fetch your fork and checkout the branch of this PR with:
git clone https://github.com/dcaputo-harmoni/open-balena-api.git
cd open-balena-api
git checkout patch-1
1b. In case you already have a local copy of the repo, then you just need to cd to it and make sure your local branch is in sync with:
git checkout patch-1
git fetch
git reset patch-1 origin:patch-1
- Then you can amend the commit and push with:
git commit --amend -m "Skip device heartbeat RSMQ records missing a deviceId property" -m "Change-type: patch"
git push origin patch-1
There was a problem hiding this comment.
Just followed these steps, although I needed to pull the latest changes before pushing, so I ran:
git config pull.rebase false
git pull
Before the git push command above. Seems it didn't like the merge, any idea how to get around that? I tried setting pull.rebase to true but then the push didn't seem to do anything.
fixes #1349
Change-type: patch