Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semver should always contain the computed term in build metadata for release.version field, never in the pre-release #1182

Open
Tschebbischeff opened this issue Dec 6, 2022 · 0 comments

Comments

@Tschebbischeff
Copy link

Tschebbischeff commented Dec 6, 2022

Referencing the changes from this issue:

[...] but the release.version computed term will be appending the extra metadata at the end the prerelease or build part, depending on the value of is_final.

In my opinion the computed term should always be appended to the build part, as it has no part in the stability of a release, but is purely information coming from building the release.

From semver.org:

A pre-release version indicates that the version is unstable and might not satisfy the intended compatibility requirements as denoted by its associated normal version.

I therefore think the pre-release term should be completely in the hands of the user and the computed term should be appended to the build metadata, regardless of the value of is_final.

Furthermore the pre-release term is relevant for ordering releases, while the build part is not. Appending the computed term to the pre-release can therefore change the precedence of two releases, when they should be equal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant