Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch router: BPT transfers and approvals #531

Open
jubeira opened this issue Apr 25, 2024 · 1 comment · May be fixed by #1079
Open

Batch router: BPT transfers and approvals #531

jubeira opened this issue Apr 25, 2024 · 1 comment · May be fixed by #1079

Comments

@jubeira
Copy link
Contributor

jubeira commented Apr 25, 2024

We're calling bpt.approve and bpt.transfer in some instances in the batch router. This is kinda inefficient because BPTs are actually facades that call the vault, which in fact calls the extension. So the chain is router --> BPT --> vault --> vault extension.

Can we move the external methods for transfer and approve from the extension to the vault, and then call the vault directly instead of using the BPT facade? In that case, the call chain would be router --> vault.

@jubeira jubeira added this to the Gas optimizations milestone Apr 25, 2024
@EndymionJkb
Copy link
Collaborator

Is this obsolete now that we have permit2, infinite self-allowance, etc.?

@EndymionJkb EndymionJkb linked a pull request Nov 13, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants