Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit Signatures - Document relevant info #369

Open
brunoguerios opened this issue Jul 24, 2024 · 1 comment
Open

Permit Signatures - Document relevant info #369

brunoguerios opened this issue Jul 24, 2024 · 1 comment
Assignees

Comments

@brunoguerios
Copy link
Member

brunoguerios commented Jul 24, 2024

Relevant info to be shared regarding using Permit and Permit2 signatures in the SDK:

  • Balancer v3 allows token approval flow to be handled through Permit and Permit2.
  • It can be done through direct approvals (ERC20 or Permit2) or through signatures.
  • To facilitate using signatures, SDK:
    • includes buildCallWithPermit that expects Permit signatures for Remove Liquidity operations
    • includes buildCallWithPermit2 that expects Permit2 signatures for Add Liquidity and Swap operations
    • provides helpers to sign Permit and Permit2 signatures
  • all permit signatures operations (swaps, add/remove liquidity) support native asset as input/output (i..e ETH)
@johngrantuk
Copy link
Member

To clarify final "docs":

  • some content to readme (including eventual limitations, such as does not support wethIsEth = true)
  • examples - I don't think we need one for each case or anything but maybe some inline comments explaining whats happening and why
  • docs site - I think its important to add this info to the docs site somewhere, maybe even its own section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants