Skip to content
This repository has been archived by the owner on Oct 26, 2021. It is now read-only.

Invalid credentials message on Bittrex is cut off #510

Open
cjdowner opened this issue Jan 27, 2018 · 4 comments
Open

Invalid credentials message on Bittrex is cut off #510

cjdowner opened this issue Jan 27, 2018 · 4 comments

Comments

@cjdowner
Copy link

cjdowner commented Jan 27, 2018

Summary
Bittrex account connect error message could be handled better.

Steps to reproduce
Go to add a new Bittrex account, but enter in a wrong/invalid API Key / Secret

Expected results
The warning should show, but as it's on two lines, the text field/button constraints should move down (whilst marginally increasing the window height). Maybe errors could be designed differently, but that's not a quick fix.

Actual results
The error message is over two lines, but there's only room for one. Turns out you can scroll.
screen shot 2018-01-27 at 09 54 15

Notes
macOS 10.13.2, BalanceOpen 1.0 Beta

Is there a missing word from this copy? "...Make sure you have right API and Secret pair.` Should be "...the right..." ?

Low priority issue.

@cjdowner cjdowner added the macOS label Jan 27, 2018
@einsteinx2 einsteinx2 self-assigned this Feb 9, 2018
@einsteinx2
Copy link
Contributor

Yeah we need to increase this size just a bit. Was fitting to Christian's design spec but it looks like that won't work. Also good catch on the copy. Both are easy fixes.

@einsteinx2
Copy link
Contributor

Pretty sure that error is coming directly from Bittrex. We'll work on improving general connection error display later. I'll make another issue for it. For now I'll just increase the size of that text area by 10pt so at least it's not cut off.

@einsteinx2
Copy link
Contributor

Actually that's not correct. It's our error. However, the errors are in the api code which is being massively refactored and is almost done, so holding off on this until that's ready.

@einsteinx2
Copy link
Contributor

Blocked on #470

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants