Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Poller #159

Open
20zurmca opened this issue Apr 14, 2022 · 0 comments
Open

Custom Poller #159

20zurmca opened this issue Apr 14, 2022 · 0 comments

Comments

@20zurmca
Copy link

20zurmca commented Apr 14, 2022

I have a use case where I need to make a custom Poller. Can we make the poller variable less ridged and provide the developer with options to use a custom poller class that inherits the Poller base class? This use case derived from making a custom threaded pub-sub transport, and I don't need the event-driven pollers.

If the idea is approved, I'll update the PR to do a check if pollerClass issubclass of Poller and I'll add to the docstring

Another thing I would like to point out but is not related to this post is that Transport class takes a SyncObj type in its constructor, and SyncObj can take a transport object. If a transport object is not given, the self keyword is passed in to the transportClass constructor which is in the PySyncObj constructor. This circular dependency makes creating a custom transport object outside of the PySyncObj constructor confusing. Maybe we can think of a redesign for the constructors so that custom transport objects can be made more intuitively.

Thanks!

@20zurmca 20zurmca changed the title Poller not Customizable Custom Poller Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant