From f00e6956fda009be8f6b84498bf72ce29a632688 Mon Sep 17 00:00:00 2001 From: kaioken Date: Tue, 9 Jul 2024 15:13:55 -0400 Subject: [PATCH 1/3] fix: workflow --- src/Domains/Connectors/Zoho/DataTransferObject/ZohoLead.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Domains/Connectors/Zoho/DataTransferObject/ZohoLead.php b/src/Domains/Connectors/Zoho/DataTransferObject/ZohoLead.php index 82d7cc1ca..cfe3ebff4 100644 --- a/src/Domains/Connectors/Zoho/DataTransferObject/ZohoLead.php +++ b/src/Domains/Connectors/Zoho/DataTransferObject/ZohoLead.php @@ -59,8 +59,7 @@ public static function fromLead(Lead $lead): self public function toArray(): array { $data = parent::toArray(); - - unset($data['additionalFields']); + //unset($data['additionalFields']); return $data; } From 1f06b8e6f55697c5286f85f81069a4b16ca7e1c9 Mon Sep 17 00:00:00 2001 From: kaioken Date: Tue, 9 Jul 2024 15:16:30 -0400 Subject: [PATCH 2/3] fix: workflow --- src/Domains/Connectors/Zoho/DataTransferObject/ZohoLead.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Domains/Connectors/Zoho/DataTransferObject/ZohoLead.php b/src/Domains/Connectors/Zoho/DataTransferObject/ZohoLead.php index cfe3ebff4..f66681f9a 100644 --- a/src/Domains/Connectors/Zoho/DataTransferObject/ZohoLead.php +++ b/src/Domains/Connectors/Zoho/DataTransferObject/ZohoLead.php @@ -95,7 +95,9 @@ protected static function mapProperties(array $map, array &$data, array $entity) $value = $creditScore[(int) $value] ?? $value; } - $data[$name] = $value; + if ($value !== null) { + $data[$name] = $value; + } } } From c5628132b5c6cac40c0c72b4f6ece07963f2dc35 Mon Sep 17 00:00:00 2001 From: kaioken Date: Tue, 9 Jul 2024 15:18:01 -0400 Subject: [PATCH 3/3] feat: add todo --- src/Domains/Connectors/Zoho/Workflows/ZohoLeadActivity.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/Domains/Connectors/Zoho/Workflows/ZohoLeadActivity.php b/src/Domains/Connectors/Zoho/Workflows/ZohoLeadActivity.php index 0a3e38c21..41641c370 100644 --- a/src/Domains/Connectors/Zoho/Workflows/ZohoLeadActivity.php +++ b/src/Domains/Connectors/Zoho/Workflows/ZohoLeadActivity.php @@ -19,6 +19,9 @@ use Webleit\ZohoCrmApi\Modules\Leads as ZohoLeadModule; use Workflow\Activity; +/** + * @todo refactor move core logic to SyncLeadWithZohoAction + */ class ZohoLeadActivity extends Activity implements WorkflowActivityInterface { use KanvasJobsTrait;