-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAJOR UPGRADE: Snapweb - GatsbyJS Edition #41
Conversation
@daredoes are you still proposing this? |
Nah, it can be closed. This was before the react branch existed
…On Mon, Jul 10, 2023 at 1:18 PM Winston Hoy ***@***.***> wrote:
@daredoes <https://github.com/daredoes> are you still proposing this?
—
Reply to this email directly, view it on GitHub
<#41 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABR4MAME7BD3IMX2O3RAK6LXPRPQZANCNFSM5Q24B3EQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Many thanks for your pull request, it looks very good. However, your changes go far beyond the implementation of a feature or a bugfix. It is much more of an independent project, so I will not merge the PR. |
@badaix up to you. I really love snapcast, I use it daily. I work full-time in React/Python. If you want help on any of the snapweb stuff you have, tag me in a ticket. |
Thanks for you offer @daredoes , I will do so 👍 |
First, and most importantly, thank you.
Snapcast, and Snapweb, have been amazing. I noticed the comment about the current iteration being a proof-of-concept typescript project for the Snapcast Websocket API, so I hope you may consider this iteration something closer to your imagined concept, if not v1.0.0.
NOW, BRACE YOURSELF
This pull request contains
snapcontrol.ts
andsnapstream.ts
into individual type files, classes, and React components.localForage
) to manage WebWorker state, and app statehttps://snapserver.com
), will be automatically transformed into the API (wss://snapserver.com/jsonrpc
) and stream (wss://snapserver.com/stream
) endpoints, or API and Stream can be set directly for edge cases (http is transformed). (Fixes Doesn't work when behind a HTTPS reverse proxy #21)api
stream
orserver
respectively.?api=https%3A%2F%2Fserver.com%0A
GATSBY_SNAPSERVER
andGATSBY_SNAPSTREAM
. This will auto-connect to the given servers during first load instead of providing a blank page (basically makes it the same as the current version in a way)Lastly, because this version is a static website, I have hosted it for free on netlify at snapweb.netlify.app. You can install it locally and try it, or test it there 🎉
Please do not feel rushed to review this pull request. Any time you have to look over the massive amount of changes is appreciated.