Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make snapweb paths configurable for ingress #109

Open
jkrenzer opened this issue Nov 4, 2024 · 0 comments
Open

Make snapweb paths configurable for ingress #109

jkrenzer opened this issue Nov 4, 2024 · 0 comments

Comments

@jkrenzer
Copy link

jkrenzer commented Nov 4, 2024

Hi!

Current State

Assume the following setup:

  • Snapweb is exposed under a sub-path by an ingress controller: https://example.com/snapcast
  • Snapcast server's JSON-RPC is exposed as https://example.com/snapcast/json-rpc by the same ingress-controller

Currently snapweb tries to call wss://example.com/json-rpc to establish a connection and there is no way to modify this behavior without recompiling for every setup.

Proposal

Make the paths for the assets and for the accessed endpoints configurable, e.g. using a config.json or config.js file which is loaded on startup and which can override the defaults.

Using a config.js would allow to generate the paths using variables available at runtime, maybe even headers provided by the reverse-proxy or ingress-controller like X-Ingress-Path.

Thanks!

Jörn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant