Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Per-domains certificates #336

Open
gaabora opened this issue Oct 7, 2024 · 1 comment
Open

[Feat]: Per-domains certificates #336

gaabora opened this issue Oct 7, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@gaabora
Copy link

gaabora commented Oct 7, 2024

What happened?

(domain names are redacted)

When visiting one of created in Cosmos-Server URLs like something.servegame.com,
cert info of the website shows list of all added domains for other services:
name.xyz
something.servegame.com

image

What should have happened?

Cert info must show only corresponded domain and never list all added domains from other added to Cosmos-Server services
One domain = one cert.

How to reproduce the bug?

  1. Having "Configuration > HTTP > Hostname" name.xyz
  2. Go to "Management > URLs > Create, then go to new record's Setup > Use host" and specify different domain name you own, like something.servegame.com

Relevant log output

No response

Other details

No response

System details

  • OS: [any]
  • Browser [any]
  • Version [latest]
@gaabora gaabora added the bug Something isn't working label Oct 7, 2024
@azukaar azukaar changed the title [BUG]: security issue: cosmos getting one letsencrypt cert for multiple different domains [BUG]: Cosmos getting one letsencrypt cert for multiple different domains Oct 7, 2024
@azukaar
Copy link
Owner

azukaar commented Oct 7, 2024

This is the intended behaviour, Cosmos does not support per-domain certificate
It is not a "security issue" or an issue at all for 99.99% cases.

I will leave the ticket opened for visibility, but at the moment splitting the cert is a very low priority item

@azukaar azukaar changed the title [BUG]: Cosmos getting one letsencrypt cert for multiple different domains [Feat]: Cosmos getting one letsencrypt cert for multiple different domains Oct 7, 2024
@azukaar azukaar added enhancement New feature or request and removed bug Something isn't working labels Oct 7, 2024
@azukaar azukaar changed the title [Feat]: Cosmos getting one letsencrypt cert for multiple different domains [Feat]: Per-domains certificates Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants