Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Use more logic operators for cosmos-compose.json #312

Open
eralumin opened this issue Sep 3, 2024 · 3 comments
Open

[FEAT]: Use more logic operators for cosmos-compose.json #312

eralumin opened this issue Sep 3, 2024 · 3 comments

Comments

@eralumin
Copy link

eralumin commented Sep 3, 2024

Feature Description

Current template engine for cosmose-compose.json seems to use whiskers.js which has some limitations, and/or operators are not implemented and the project itself seems dead.

@madejackson
Copy link
Contributor

I'd support this. whiskers.js is too limited. Several template frameworks I used in the past, f.e. mustache or jinja, are more feature rich.

Porting the json-files from whiskers to jinja f.e. should be fairly easy (simple regex replace). mustache probably not so much as it's logic-less and hence would have to be done manually.

@azukaar
Copy link
Owner

azukaar commented Sep 9, 2024

While I do agree that improvement can be made, it would need to be done in a way that keeps the retro-compatibility with existing cosmos-compose, which I think is quite a challenge and is not possible by just "migrating" all the files to a new format, because there are multiple stores out there that i not maintained by me

@madejackson
Copy link
Contributor

I think at least in the case of jinja, this should be doable with a simple translation layer for a limited time period to give maintainers enough time to update their repos. I could support you with doing the necessary PR's in the publicly known repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants