Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] version 2.0 #237

Closed
azjezz opened this issue Oct 16, 2021 · 6 comments
Closed

[meta] version 2.0 #237

azjezz opened this issue Oct 16, 2021 · 6 comments
Assignees
Projects
Milestone

Comments

@azjezz
Copy link
Owner

azjezz commented Oct 16, 2021

new components:

features:

  • [Type] support native PHP 8.1 enums

backward compatibility breaking changes:

other:

  • drop support for PHP 8.0
@azjezz azjezz added this to the 2.0.0 milestone Oct 16, 2021
@azjezz azjezz self-assigned this Oct 16, 2021
@azjezz
Copy link
Owner Author

azjezz commented Oct 16, 2021

@veewee are you aware of any other places where we can make use of enums instead of scalar arguments? 🤔

@veewee
Copy link
Collaborator

veewee commented Oct 18, 2021

Scrolled to the source - but havent found much of those.
Not sure if possible, but maybe one that covers all hash_algos?
https://github.com/azjezz/psl/blob/1.9.x/src/Psl/Hash/algorithms.php

@azjezz azjezz added this to In progress in v2.0.0 Nov 4, 2021
@azjezz azjezz pinned this issue Nov 8, 2021
@azjezz azjezz moved this from In progress to Done in v2.0.0 May 7, 2022
@simPod
Copy link
Contributor

simPod commented May 11, 2022

What is the recommended way to install that?

azjezz/psl 2.0.0 requires revolt/event-loop dev-main -> found revolt/event-loop[dev-main, 1.x-dev (alias of dev-main)] but it does not match your minimum-stability. but I don't really want to allow minimum-stability: dev

@azjezz
Copy link
Owner Author

azjezz commented May 11, 2022

oh shout! i completely missed that!

there has been a new release for revolt ( https://github.com/revoltphp/event-loop/releases/tag/v0.2.4 ), so PSL should use that instead of dev-main.

@simPod can you send a PR for this? otherwise, i can do this tomorrow evening.

@simPod
Copy link
Contributor

simPod commented May 11, 2022

Here #348

@azjezz
Copy link
Owner Author

azjezz commented May 11, 2022

released 2.0.1 with the fix, thank you :)

@azjezz azjezz closed this as completed Mar 17, 2024
@azjezz azjezz unpinned this issue Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants