Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incoming-pr branch is outdated, so that it is impossible to foollow guidelines for contributing #198

Open
evilaliv3 opened this issue Jan 8, 2016 · 2 comments

Comments

@evilaliv3
Copy link
Contributor

incoming-pr branch, cited by guidelines for contributing

i think you should take care of changin the guidelines if no more needed or rebase the incoming-pr branch to latest master.

spotted while trying to following the guidelines for opening the pull request: #197

\cc @axemclion @Jonahss

@axemclion
Copy link
Owner

@Jonahss Should we revise the guidelines ? I think we should simply ask for PRs to be against master. I had originally done the incoming-pr branch so as to not break master, and have the sauce key private, but clearly that did not work.

@Jonahss
Copy link
Collaborator

Jonahss commented Jan 11, 2016

Yeah we can just edit the docs and go to a regular PR to master system.

On Fri, Jan 8, 2016 at 8:14 AM, Parashuram N [email protected]
wrote:

@Jonahss https://github.com/Jonahss Should we revise the guidelines ? I
think we should simply ask for PRs to be against master. I had originally
done the incoming-pr branch so as to not break master, and have the sauce
key private, but clearly that did not work.


Reply to this email directly or view it on GitHub
#198 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants